PMD Results

The following document contains the results of PMD 4.2.2.

Files

ca/sqlpower/wabit/AbstractWabitObject.java

Violation Line
Avoid unused private fields such as 'logger'. 34
Ensure you override both equals() and hashCode() 156
These nested if statements could be combined 158 - 160

ca/sqlpower/wabit/dao/json/WabitJSONPersister.java

Violation Line
Avoid unused private fields such as 'logger'. 40

ca/sqlpower/wabit/dao/OpenWorkspaceXMLDAO.java

Violation Line
Avoid empty catch blocks 161 - 163

ca/sqlpower/wabit/dao/PersistedPropertiesEntry.java

Violation Line
Avoid unused constructor parameters such as 'propertyType'. 31 - 39

ca/sqlpower/wabit/dao/session/WorkspacePersisterListener.java

Violation Line
Avoid empty if statements 444 - 448

ca/sqlpower/wabit/dao/WabitSessionPersister.java

Violation Line
Avoid empty catch blocks 702 - 704
Avoid unused method parameters such as 'newValue'. 1756 - 1764
Avoid unused method parameters such as 'newValue'. 1809 - 1814
Avoid unused method parameters such as 'newValue'. 2449 - 2454
Avoid unused method parameters such as 'newValue'. 2498 - 2503
Avoid unused method parameters such as 'newValue'. 2877 - 2881
Avoid unused method parameters such as 'newValue'. 3096 - 3101
Avoid empty if statements 3183 - 3186
Avoid unused method parameters such as 'newValue'. 3833 - 3837
Avoid unused method parameters such as 'newValue'. 3882 - 3887
Avoid unused method parameters such as 'newValue'. 3929 - 3934

ca/sqlpower/wabit/dao/WorkspaceSAXHandler.java

Violation Line
Avoid unused private fields such as 'columnInfoList'. 180
Avoid unused method parameters such as 'uri'. 338 - 1240
Avoid unused method parameters such as 'localName'. 338 - 1240
Avoid empty if statements 478 - 480
Avoid empty if statements 480 - 482
Avoid empty if statements 524 - 526
Avoid empty if statements 547 - 549
Avoid empty if statements 572 - 574
Avoid empty if statements 599 - 601
Avoid empty if statements 645 - 647
Avoid empty if statements 699 - 701
Avoid empty if statements 777 - 779
Avoid empty if statements 791 - 793
Avoid empty if statements 852 - 854
Avoid empty if statements 889 - 891
Avoid empty if statements 922 - 924
Avoid empty if statements 928 - 930
Avoid empty if statements 941 - 943
Avoid empty if statements 962 - 964
Avoid empty if statements 991 - 993
Avoid empty if statements 1031 - 1033
Avoid empty if statements 1033 - 1035
Avoid empty if statements 1035 - 1037
Avoid empty if statements 1051 - 1053
Avoid empty if statements 1053 - 1055
Avoid empty if statements 1117 - 1119
Avoid unused local variables such as 'uuid'. 1161
Avoid empty if statements 1179 - 1181
Avoid empty if statements 1181 - 1183
Avoid unused method parameters such as 'uri'. 1384 - 1464
Avoid unused method parameters such as 'localName'. 1384 - 1464
Avoid unused local variables such as 'initialView'. 1390

ca/sqlpower/wabit/dao/WorkspaceXMLDAO.java

Violation Line
Avoid empty if statements 390 - 392
Avoid unused method parameters such as 'out'. 540 - 544

ca/sqlpower/wabit/enterprise/client/ServerInfoProvider.java

Violation Line
Avoid empty catch blocks 170 - 172

ca/sqlpower/wabit/enterprise/client/WabitClientSession.java

Violation Line
Avoid empty catch blocks 187 - 189

ca/sqlpower/wabit/report/CellSetRenderer.java

Violation Line
Avoid unused method parameters such as 'columnWidthList'. 415 - 458

ca/sqlpower/wabit/report/chart/Chart.java

Violation Line
Avoid unused imports such as 'org.olap4j.CellSet' 35
Avoid unused local variables such as 'oldUnfilteredResults'. 321
Avoid unused private methods such as 'removeAllColumns()'. 378
Overriding method merely calls super 441 - 443

ca/sqlpower/wabit/report/chart/DatasetUtil.java

Violation Line
Avoid unused local variables such as 'j'. 99

ca/sqlpower/wabit/report/ContentBox.java

Violation Line
Avoid unused private fields such as 'logger'. 51

ca/sqlpower/wabit/report/ImageRenderer.java

Violation Line
These nested if statements could be combined 104 - 106

ca/sqlpower/wabit/report/Page.java

Violation Line
These nested if statements could be combined 321 - 329
These nested if statements could be combined 503 - 505
These nested if statements could be combined 515 - 517

ca/sqlpower/wabit/report/Report.java

Violation Line
Avoid unused constructor parameters such as 'session'. 52 - 60

ca/sqlpower/wabit/report/Template.java

Violation Line
Avoid unused constructor parameters such as 'session'. 49 - 57

ca/sqlpower/wabit/rs/olap/WabitOlapSelection.java

Violation Line
Avoid unused private fields such as 'logger'. 39

ca/sqlpower/wabit/rs/query/WabitJoin.java

Violation Line
Avoid unused private fields such as 'logger'. 45

ca/sqlpower/wabit/rs/ResultSetProducerSupport.java

Violation Line
Avoid unused imports such as 'java.sql.ResultSet' 22

ca/sqlpower/wabit/swingui/action/AboutAction.java

Violation Line
Avoid unused imports such as 'javax.swing.JLabel' 33
Avoid unused imports such as 'net.miginfocom.swing.MigLayout' 36
Avoid unused imports such as 'ca.sqlpower.wabit.swingui.WabitSwingSessionImpl' 43

ca/sqlpower/wabit/swingui/action/CopyAction.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.swingui.WorkspacePanel' 39

ca/sqlpower/wabit/swingui/action/CopyQueryAction.java

Violation Line
Avoid unused imports such as 'java.awt.event.ActionEvent' 23

ca/sqlpower/wabit/swingui/action/CopyTemplateAction.java

Violation Line
Avoid unused imports such as 'java.awt.event.ActionEvent' 23

ca/sqlpower/wabit/swingui/action/OpenWorkspaceAction.java

Violation Line
Avoid empty catch blocks 203

ca/sqlpower/wabit/swingui/chart/ChartPanel.java

Violation Line
Avoid unused private fields such as 'chartHasChanges'. 227

ca/sqlpower/wabit/swingui/chart/ChartSwingUtil.java

Violation Line
Avoid empty if statements 199 - 202

ca/sqlpower/wabit/swingui/chart/WabitJFreeChartPanel.java

Violation Line
Overriding method merely calls super 41 - 43

ca/sqlpower/wabit/swingui/chart/XYChartHeaderRenderer.java

Violation Line
Avoid empty if statements 328 - 330

ca/sqlpower/wabit/swingui/enterprise/ReportTaskPanel.java

Violation Line
Avoid unused method parameters such as 'selectedItem'. 273 - 322

ca/sqlpower/wabit/swingui/olap/CellSetTableHeaderComponent.java

Violation Line
Avoid unused private fields such as 'preferredSizes'. 112

ca/sqlpower/wabit/swingui/olap/OlapQueryPanel.java

Violation Line
Avoid empty catch blocks 528 - 530

ca/sqlpower/wabit/swingui/olap/SlicerPanel.java

Violation Line
Avoid unused method parameters such as 'isMousePressed'. 293 - 313

ca/sqlpower/wabit/swingui/query/QueryPropertiesPanel.java

Violation Line
Avoid empty if statements 129 - 131

ca/sqlpower/wabit/swingui/QueryPanel.java

Violation Line
Avoid unused private fields such as 'EXPAND_ACTION'. 224
Avoid unused local variables such as 'name'. 728

ca/sqlpower/wabit/swingui/report/ChartSwingRenderer.java

Violation Line
Avoid unused constructor parameters such as 'renderer'. 42 - 44
Avoid unused constructor parameters such as 'workspace'. 42 - 44

ca/sqlpower/wabit/swingui/report/ContentBoxNode.java

Violation Line
An empty statement (semicolon) not part of a loop 365
These nested if statements could be combined 419 - 422

ca/sqlpower/wabit/swingui/report/ImageSwingRenderer.java

Violation Line
Avoid unused constructor parameters such as 'workspace'. 61 - 126
These nested if statements could be combined 209 - 211

ca/sqlpower/wabit/swingui/report/ResultSetSwingRenderer.java

Violation Line
These nested if statements could be combined 411 - 413

ca/sqlpower/wabit/swingui/tree/WorkspaceTreeCellEditor.java

Violation Line
These nested if statements could be combined 58 - 60

ca/sqlpower/wabit/swingui/tree/WorkspaceTreeCellRenderer.java

Violation Line
These nested if statements could be combined 236 - 238

ca/sqlpower/wabit/swingui/WabitSwingSessionContextImpl.java

Violation Line
Avoid empty if statements 1879 - 1881

ca/sqlpower/wabit/swingui/WabitWelcomeScreen.java

Violation Line
Avoid unused local variables such as 'serverListMenuItemFactory'. 143

ca/sqlpower/wabit/swingui/WorkspaceGraphTreeModel.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.WabitObject' 30

ca/sqlpower/wabit/swingui/WorkspaceGraphTreeNodeWrapper.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.WabitObject' 26

ca/sqlpower/wabit/swingui/WorkspacePanel.java

Violation Line
Avoid empty catch blocks 327 - 329
Avoid empty catch blocks 364 - 366

ca/sqlpower/wabit/swingui/WorkspaceTreeListener.java

Violation Line
These nested if statements could be combined 129 - 140

ca/sqlpower/wabit/WabitUtils.java

Violation Line
Avoid unused private fields such as 'logger'. 33

ca/sqlpower/wabit/WabitWorkspace.java

Violation Line
Avoid unused method parameters such as 'session'. 322 - 335

org/json/JSONArray.java

Violation Line
An empty statement (semicolon) not part of a loop 181

org/json/JSONObject.java

Violation Line
Unnecessary final modifier in final class 103 - 105
Ensure you override both equals() and hashCode() 114
Avoid empty catch blocks 403 - 405
Avoid empty catch blocks 1241 - 1243
Avoid empty catch blocks 1247 - 1249
Avoid empty catch blocks 1263 - 1265
These nested if statements could be combined 1284 - 1287
Avoid empty catch blocks 1503 - 1505

org/json/XML.java

Violation Line
These nested if statements could be combined 161 - 167
These nested if statements could be combined 263 - 273