PMD Results

The following document contains the results of PMD 4.2.2.

Files

ca/sqlpower/wabit/AbstractWabitObject.java

Violation Line
Ensure you override both equals() and hashCode() 505
These nested if statements could be combined 507 - 509

ca/sqlpower/wabit/WabitBackgroundWorker.java

Violation Line
Avoid unused imports such as 'java.beans.PropertyChangeListener' 22

ca/sqlpower/wabit/WabitJoin.java

Violation Line
Avoid unused private fields such as 'logger'. 40

ca/sqlpower/wabit/WabitObject.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.dao.WabitObjectProperty' 27
Avoid unused imports such as 'com.google.common.collect.Multimap' 29

ca/sqlpower/wabit/WabitWorkspace.java

Violation Line
Avoid unused method parameters such as 'session'. 295 - 308

ca/sqlpower/wabit/dao/OpenWorkspaceXMLDAO.java

Violation Line
Avoid empty catch blocks 161 - 163

ca/sqlpower/wabit/dao/PersistedPropertiesEntry.java

Violation Line
Avoid unused constructor parameters such as 'propertyType'. 31 - 39

ca/sqlpower/wabit/dao/PersistedWabitObject.java

Violation Line
Ensure you override both equals() and hashCode() 104

ca/sqlpower/wabit/dao/RemovedWabitObject.java

Violation Line
Ensure you override both equals() and hashCode() 51

ca/sqlpower/wabit/dao/WabitObjectProperty.java

Violation Line
Ensure you override both equals() and hashCode() 110

ca/sqlpower/wabit/dao/WabitSessionPersister.java

Violation Line
Avoid empty catch blocks 389 - 391
Avoid unused method parameters such as 'newValue'. 1413 - 1421
Avoid unused method parameters such as 'newValue'. 1466 - 1471
Avoid unused method parameters such as 'newValue'. 2106 - 2111
Avoid unused method parameters such as 'newValue'. 2155 - 2160
Avoid unused method parameters such as 'newValue'. 2534 - 2538
Avoid unused method parameters such as 'newValue'. 2753 - 2758
Avoid empty if statements 2840 - 2843
Avoid unused method parameters such as 'newValue'. 3490 - 3494
Avoid unused method parameters such as 'newValue'. 3539 - 3544
Avoid unused method parameters such as 'newValue'. 3586 - 3591

ca/sqlpower/wabit/dao/WorkspaceSAXHandler.java

Violation Line
Avoid unused private fields such as 'columnInfoList'. 179
Avoid unused method parameters such as 'localName'. 337 - 1239
Avoid unused method parameters such as 'uri'. 337 - 1239
Avoid empty if statements 477 - 479
Avoid empty if statements 479 - 481
Avoid empty if statements 523 - 525
Avoid empty if statements 546 - 548
Avoid empty if statements 571 - 573
Avoid empty if statements 598 - 600
Avoid empty if statements 644 - 646
Avoid empty if statements 698 - 700
Avoid empty if statements 776 - 778
Avoid empty if statements 790 - 792
Avoid empty if statements 851 - 853
Avoid empty if statements 888 - 890
Avoid empty if statements 921 - 923
Avoid empty if statements 927 - 929
Avoid empty if statements 940 - 942
Avoid empty if statements 961 - 963
Avoid empty if statements 990 - 992
Avoid empty if statements 1030 - 1032
Avoid empty if statements 1032 - 1034
Avoid empty if statements 1034 - 1036
Avoid empty if statements 1050 - 1052
Avoid empty if statements 1052 - 1054
Avoid empty if statements 1116 - 1118
Avoid unused local variables such as 'uuid'. 1160
Avoid empty if statements 1178 - 1180
Avoid empty if statements 1180 - 1182
Avoid unused method parameters such as 'localName'. 1383 - 1463
Avoid unused method parameters such as 'uri'. 1383 - 1463
Avoid unused local variables such as 'initialView'. 1389

ca/sqlpower/wabit/dao/WorkspaceXMLDAO.java

Violation Line
Avoid empty if statements 388 - 390
Avoid unused method parameters such as 'out'. 538 - 542

ca/sqlpower/wabit/dao/session/WorkspacePersisterListener.java

Violation Line
Avoid empty if statements 431 - 435
Avoid empty if statements 793 - 796

ca/sqlpower/wabit/enterprise/client/ServerInfoProvider.java

Violation Line
Avoid empty catch blocks 142 - 144
Avoid empty catch blocks 147 - 149

ca/sqlpower/wabit/enterprise/client/WabitServerSession.java

Violation Line
Avoid empty catch blocks 154 - 156

ca/sqlpower/wabit/enterprise/client/security/CachingWabitAccessManager.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.WabitObject' 24
Avoid unused imports such as 'ca.sqlpower.wabit.WabitSession' 25
Avoid unused imports such as 'ca.sqlpower.wabit.enterprise.client.User' 26

ca/sqlpower/wabit/enterprise/client/security/GrantCache.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.WabitObject' 13

ca/sqlpower/wabit/olap/WabitOlapSelection.java

Violation Line
Avoid unused private fields such as 'logger'. 38

ca/sqlpower/wabit/report/CellSetRenderer.java

Violation Line
Avoid unused method parameters such as 'columnWidthList'. 414 - 457

ca/sqlpower/wabit/report/ContentBox.java

Violation Line
Avoid unused private fields such as 'logger'. 49
Avoid empty if statements 132 - 135

ca/sqlpower/wabit/report/Page.java

Violation Line
These nested if statements could be combined 462 - 464
These nested if statements could be combined 474 - 476

ca/sqlpower/wabit/report/Report.java

Violation Line
Avoid unused constructor parameters such as 'session'. 52 - 60

ca/sqlpower/wabit/report/Template.java

Violation Line
Avoid unused constructor parameters such as 'session'. 49 - 57

ca/sqlpower/wabit/report/chart/Chart.java

Violation Line
Avoid unused imports such as 'org.olap4j.CellSet' 35
Avoid unused local variables such as 'oldUnfilteredResults'. 320
Avoid unused private methods such as 'removeAllColumns()'. 374
Overriding method merely calls super 437 - 439

ca/sqlpower/wabit/report/chart/DatasetUtil.java

Violation Line
Avoid unused local variables such as 'j'. 99

ca/sqlpower/wabit/rs/ResultSetProducerSupport.java

Violation Line
Avoid unused imports such as 'java.sql.ResultSet' 22

ca/sqlpower/wabit/swingui/LogInToServerAction.java

Violation Line
Avoid unused private fields such as 'logger'. 40

ca/sqlpower/wabit/swingui/QueryPanel.java

Violation Line
Avoid unused private fields such as 'EXPAND_ACTION'. 224
Avoid unused local variables such as 'name'. 721

ca/sqlpower/wabit/swingui/WabitImagePanel.java

Violation Line
Avoid unused imports such as 'java.beans.PropertyChangeListener' 39

ca/sqlpower/wabit/swingui/WabitSwingSessionContext.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.sqlobject.SQLObjectException' 28

ca/sqlpower/wabit/swingui/WabitSwingSessionContextImpl.java

Violation Line
Avoid empty if statements 1804 - 1806

ca/sqlpower/wabit/swingui/WorkspacePanel.java

Violation Line
Avoid empty catch blocks 327 - 329
Avoid empty catch blocks 364 - 366

ca/sqlpower/wabit/swingui/WorkspaceTreeListener.java

Violation Line
These nested if statements could be combined 119 - 130

ca/sqlpower/wabit/swingui/action/AboutAction.java

Violation Line
Avoid unused imports such as 'javax.swing.JLabel' 33
Avoid unused imports such as 'net.miginfocom.swing.MigLayout' 36
Avoid unused imports such as 'ca.sqlpower.wabit.swingui.WabitSwingSessionImpl' 43

ca/sqlpower/wabit/swingui/action/CopyAction.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.swingui.WorkspacePanel' 39

ca/sqlpower/wabit/swingui/action/CopyQueryAction.java

Violation Line
Avoid unused imports such as 'java.awt.event.ActionEvent' 23

ca/sqlpower/wabit/swingui/action/CopyTemplateAction.java

Violation Line
Avoid unused imports such as 'java.awt.event.ActionEvent' 23

ca/sqlpower/wabit/swingui/action/OpenWorkspaceAction.java

Violation Line
Avoid empty catch blocks 203

ca/sqlpower/wabit/swingui/chart/ChartPanel.java

Violation Line
Avoid unused private fields such as 'chartHasChanges'. 227

ca/sqlpower/wabit/swingui/chart/ChartSwingUtil.java

Violation Line
Avoid unused imports such as 'java.awt.geom.Rectangle2D' 26
Avoid unused imports such as 'org.apache.log4j.Priority' 32
Avoid unused imports such as 'org.jfree.data.general.PieDataset' 59
Avoid empty if statements 202 - 205

ca/sqlpower/wabit/swingui/chart/WabitJFreeChartPanel.java

Violation Line
Overriding method merely calls super 41 - 43

ca/sqlpower/wabit/swingui/chart/XYChartHeaderRenderer.java

Violation Line
Avoid empty if statements 328 - 330

ca/sqlpower/wabit/swingui/enterprise/ReportTaskPanel.java

Violation Line
Avoid unused method parameters such as 'selectedItem'. 260 - 309

ca/sqlpower/wabit/swingui/olap/CellSetTableHeaderComponent.java

Violation Line
Avoid unused private fields such as 'preferredSizes'. 112

ca/sqlpower/wabit/swingui/olap/OlapQueryPanel.java

Violation Line
Avoid empty catch blocks 528 - 530

ca/sqlpower/wabit/swingui/olap/SlicerPanel.java

Violation Line
Avoid unused method parameters such as 'isMousePressed'. 293 - 313

ca/sqlpower/wabit/swingui/olap/action/DrillReplaceAction.java

Violation Line
Avoid unused imports such as 'org.olap4j.OlapException' 22

ca/sqlpower/wabit/swingui/olap/action/RemoveHierarchyAction.java

Violation Line
Avoid unused imports such as 'org.olap4j.OlapException' 23

ca/sqlpower/wabit/swingui/query/QueryPropertiesPanel.java

Violation Line
Avoid empty if statements 129 - 131

ca/sqlpower/wabit/swingui/report/ChartSwingRenderer.java

Violation Line
Avoid unused constructor parameters such as 'workspace'. 42 - 44
Avoid unused constructor parameters such as 'renderer'. 42 - 44

ca/sqlpower/wabit/swingui/report/ContentBoxNode.java

Violation Line
An empty statement (semicolon) not part of a loop 365
These nested if statements could be combined 419 - 422

ca/sqlpower/wabit/swingui/report/ImageSwingRenderer.java

Violation Line
Avoid unused constructor parameters such as 'workspace'. 61 - 126
These nested if statements could be combined 209 - 211

ca/sqlpower/wabit/swingui/report/PDFAction.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.report.Report' 46

ca/sqlpower/wabit/swingui/report/PageNode.java

Violation Line
Avoid unused imports such as 'java.beans.PropertyChangeListener' 24

ca/sqlpower/wabit/swingui/report/PrintPreviewAction.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.report.Report' 49

ca/sqlpower/wabit/swingui/report/ReportPrintPreviewPanel.java

Violation Line
Avoid unused imports such as 'ca.sqlpower.wabit.report.Report' 29

ca/sqlpower/wabit/swingui/report/ResultSetSwingRenderer.java

Violation Line
These nested if statements could be combined 411 - 413

ca/sqlpower/wabit/swingui/tree/WorkspaceTreeCellEditor.java

Violation Line
Avoid unused imports such as 'java.util.EventObject' 27
These nested if statements could be combined 59 - 61

ca/sqlpower/wabit/swingui/tree/WorkspaceTreeCellRenderer.java

Violation Line
These nested if statements could be combined 235 - 237

org/json/JSONArray.java

Violation Line
An empty statement (semicolon) not part of a loop 181

org/json/JSONObject.java

Violation Line
Unnecessary final modifier in final class 103 - 105
Ensure you override both equals() and hashCode() 114
Avoid empty catch blocks 403 - 405
Avoid empty catch blocks 1241 - 1243
Avoid empty catch blocks 1247 - 1249
Avoid empty catch blocks 1263 - 1265
These nested if statements could be combined 1284 - 1287
Avoid empty catch blocks 1503 - 1505

org/json/XML.java

Violation Line
These nested if statements could be combined 161 - 167
These nested if statements could be combined 263 - 273