| # | File | Line | Problem |
| 1 |
ca/sqlpower/matchmaker/CleanseEngineImpl.java |
184 |
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. |
| 2 |
ca/sqlpower/matchmaker/DQguruEngineRunner.java |
36 |
Avoid unused imports such as 'ca.sqlpower.util.UnknownFreqCodeException' |
| 3 |
ca/sqlpower/matchmaker/MatchMakerSession.java |
26 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.dao.hibernate.MatchMakerHibernateSessionContext' |
| 4 |
ca/sqlpower/matchmaker/MatchMakerSession.java |
28 |
Avoid unused imports such as 'ca.sqlpower.sql.SPDataSource' |
| 5 |
ca/sqlpower/matchmaker/MatchPool.java |
39 |
Avoid unused imports such as 'java.util.concurrent.CancellationException' |
| 6 |
ca/sqlpower/matchmaker/MatchPool.java |
265 |
These nested if statements could be combined |
| 7 |
ca/sqlpower/matchmaker/MergeProcessor.java |
221 |
These nested if statements could be combined |
| 8 |
ca/sqlpower/matchmaker/MergeProcessor.java |
867 |
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. |
| 9 |
ca/sqlpower/matchmaker/MungeSettings.java |
25 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.address.AddressValidator' |
| 10 |
ca/sqlpower/matchmaker/RowSetModel.java |
227 |
Avoid empty catch blocks |
| 11 |
ca/sqlpower/matchmaker/RowSetModel.java |
241 |
Avoid empty catch blocks |
| 12 |
ca/sqlpower/matchmaker/address/Address.java |
689 |
Avoid empty catch blocks |
| 13 |
ca/sqlpower/matchmaker/address/Address.java |
827 |
Avoid empty catch blocks |
| 14 |
ca/sqlpower/matchmaker/address/Address.java |
947 |
Method call on object which may be null |
| 15 |
ca/sqlpower/matchmaker/address/AddressDatabase.java |
183 |
Avoid empty catch blocks |
| 16 |
ca/sqlpower/matchmaker/address/AddressDatabase.java |
218 |
Avoid empty catch blocks |
| 17 |
ca/sqlpower/matchmaker/address/AddressDatabase.java |
291 |
Avoid empty catch blocks |
| 18 |
ca/sqlpower/matchmaker/address/AddressValidator.java |
252 |
These nested if statements could be combined |
| 19 |
ca/sqlpower/matchmaker/address/PostalCode.java |
569 |
Avoid empty catch blocks |
| 20 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
40 |
An empty statement (semicolon) not part of a loop |
| 21 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
65 |
Avoid empty finally blocks |
| 22 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
85 |
Avoid empty finally blocks |
| 23 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
165 |
Avoid empty finally blocks |
| 24 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
191 |
Avoid empty finally blocks |
| 25 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
277 |
Avoid empty finally blocks |
| 26 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
333 |
Avoid empty finally blocks |
| 27 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
400 |
Avoid empty finally blocks |
| 28 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
457 |
Avoid empty finally blocks |
| 29 |
ca/sqlpower/matchmaker/address/parse/AddressLexer.java |
515 |
Avoid empty finally blocks |
| 30 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
143 |
Avoid empty catch blocks |
| 31 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
264 |
Avoid empty finally blocks |
| 32 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
266 |
Avoid unnecessary return statements |
| 33 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
315 |
Avoid empty finally blocks |
| 34 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
317 |
Avoid unnecessary return statements |
| 35 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
356 |
Avoid empty finally blocks |
| 36 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
358 |
Avoid unnecessary return statements |
| 37 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
392 |
Avoid empty finally blocks |
| 38 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
394 |
Avoid unnecessary return statements |
| 39 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
471 |
Avoid empty finally blocks |
| 40 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
473 |
Avoid unnecessary return statements |
| 41 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
717 |
Avoid empty finally blocks |
| 42 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
719 |
Avoid unnecessary return statements |
| 43 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
922 |
Avoid empty finally blocks |
| 44 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
924 |
Avoid unnecessary return statements |
| 45 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
957 |
Avoid empty finally blocks |
| 46 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
959 |
Avoid unnecessary return statements |
| 47 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1138 |
Avoid empty finally blocks |
| 48 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1140 |
Avoid unnecessary return statements |
| 49 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1201 |
Using multiple unary operators may be a bug, and/or is confusing. |
| 50 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1234 |
Avoid empty finally blocks |
| 51 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1236 |
Avoid unnecessary return statements |
| 52 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1363 |
Avoid empty finally blocks |
| 53 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1365 |
Avoid unnecessary return statements |
| 54 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1527 |
Avoid empty finally blocks |
| 55 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1529 |
Avoid unnecessary return statements |
| 56 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1861 |
Avoid empty finally blocks |
| 57 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1863 |
Avoid unnecessary return statements |
| 58 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1902 |
Avoid empty finally blocks |
| 59 |
ca/sqlpower/matchmaker/address/parse/AddressParser.java |
1904 |
Avoid unnecessary return statements |
| 60 |
ca/sqlpower/matchmaker/address/steps/LockBoxNumberStep.java |
37 |
Avoid unnecessary temporaries when converting primitives to Strings |
| 61 |
ca/sqlpower/matchmaker/address/steps/RouteDINameAndTypeStep.java |
64 |
Avoid unnecessary temporaries when converting primitives to Strings |
| 62 |
ca/sqlpower/matchmaker/address/steps/RouteNumberStep.java |
36 |
Avoid unnecessary temporaries when converting primitives to Strings |
| 63 |
ca/sqlpower/matchmaker/address/steps/RouteNumberStep.java |
39 |
Avoid unnecessary temporaries when converting primitives to Strings |
| 64 |
ca/sqlpower/matchmaker/address/steps/RouteNumberStep.java |
40 |
Avoid unnecessary temporaries when converting primitives to Strings |
| 65 |
ca/sqlpower/matchmaker/address/steps/SuiteNumberRangeStep.java |
71 |
Avoid empty if statements |
| 66 |
ca/sqlpower/matchmaker/address/steps/SuiteNumberRangeStep.java |
92 |
Avoid empty if statements |
| 67 |
ca/sqlpower/matchmaker/address/steps/ValidateStepUtil.java |
61 |
Avoid empty catch blocks |
| 68 |
ca/sqlpower/matchmaker/address/steps/ValidateStepUtil.java |
71 |
Avoid empty catch blocks |
| 69 |
ca/sqlpower/matchmaker/address/steps/ValidateStepUtil.java |
81 |
Avoid empty catch blocks |
| 70 |
ca/sqlpower/matchmaker/address/steps/ValidateStepUtil.java |
91 |
Avoid empty catch blocks |
| 71 |
ca/sqlpower/matchmaker/address/steps/ValidateStepUtil.java |
125 |
Avoid empty if statements |
| 72 |
ca/sqlpower/matchmaker/dao/hibernate/MatchMakerHibernateSessionContext.java |
37 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.swingui.SwingSessionContextImpl' |
| 73 |
ca/sqlpower/matchmaker/dao/hibernate/MatchMakerHibernateSessionContext.java |
216 |
These nested if statements could be combined |
| 74 |
ca/sqlpower/matchmaker/dao/hibernate/RepositoryUtil.java |
554 |
These nested if statements could be combined |
| 75 |
ca/sqlpower/matchmaker/dao/xml/ProjectSAXHandler.java |
334 |
Avoid empty if statements |
| 76 |
ca/sqlpower/matchmaker/dao/xml/ProjectSAXHandler.java |
363 |
Avoid empty if statements |
| 77 |
ca/sqlpower/matchmaker/dao/xml/ProjectSAXHandler.java |
431 |
Avoid empty if statements |
| 78 |
ca/sqlpower/matchmaker/dao/xml/ProjectSAXHandler.java |
490 |
Avoid empty if statements |
| 79 |
ca/sqlpower/matchmaker/dao/xml/ProjectSAXHandler.java |
715 |
These nested if statements could be combined |
| 80 |
ca/sqlpower/matchmaker/graph/GraphConsideringOnlyGivenNodes.java |
98 |
These nested if statements could be combined |
| 81 |
ca/sqlpower/matchmaker/graph/GraphConsideringOnlyGivenNodes.java |
115 |
These nested if statements could be combined |
| 82 |
ca/sqlpower/matchmaker/graph/MatchPoolGraphModel.java |
30 |
Avoid unused imports such as 'ca.sqlpower.graph.BreadthFirstSearch' |
| 83 |
ca/sqlpower/matchmaker/graph/NonDirectedUserValidatedMatchPoolGraphModel.java |
83 |
Avoid empty if statements |
| 84 |
ca/sqlpower/matchmaker/munge/AbstractMungeStep.java |
41 |
Avoid unused imports such as 'ca.sqlpower.sqlobject.SQLType' |
| 85 |
ca/sqlpower/matchmaker/munge/MungeProcess.java |
29 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.PotentialMatchRecord' |
| 86 |
ca/sqlpower/matchmaker/munge/SQLInputStep.java |
202 |
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. |
| 87 |
ca/sqlpower/matchmaker/swingui/BuildExampleTableDialog.java |
609 |
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. |
| 88 |
ca/sqlpower/matchmaker/swingui/DeriveRelatedRulesPanel.java |
270 |
These nested if statements could be combined |
| 89 |
ca/sqlpower/matchmaker/swingui/DeriveRelatedRulesPanel.java |
402 |
These nested if statements could be combined |
| 90 |
ca/sqlpower/matchmaker/swingui/DisplayedNodeValueChooser.java |
229 |
Avoid empty if statements |
| 91 |
ca/sqlpower/matchmaker/swingui/JTextAreaUndoWrapper.java |
91 |
Avoid empty catch blocks |
| 92 |
ca/sqlpower/matchmaker/swingui/JTextAreaUndoWrapper.java |
102 |
Avoid empty catch blocks |
| 93 |
ca/sqlpower/matchmaker/swingui/MMSUtils.java |
193 |
Avoid returning from a finally block |
| 94 |
ca/sqlpower/matchmaker/swingui/MatchMakerSwingSession.java |
706 |
These nested if statements could be combined |
| 95 |
ca/sqlpower/matchmaker/swingui/MatchMakerSwingSession.java |
1088 |
An empty statement (semicolon) not part of a loop |
| 96 |
ca/sqlpower/matchmaker/swingui/MatchMakerSwingSession.java |
1094 |
An empty statement (semicolon) not part of a loop |
| 97 |
ca/sqlpower/matchmaker/swingui/MatchMakerSwingSession.java |
1216 |
These nested if statements could be combined |
| 98 |
ca/sqlpower/matchmaker/swingui/MatchMakerSwingUserSettings.java |
23 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.MatchMakerSessionContext' |
| 99 |
ca/sqlpower/matchmaker/swingui/MergeColumnRuleEditor.java |
91 |
These nested if statements could be combined |
| 100 |
ca/sqlpower/matchmaker/swingui/MergeTableRuleEditor.java |
48 |
Avoid unused imports such as 'ca.sqlpower.matchmaker.TableMergeRules.ChildMergeActionType' |
| 101 |
ca/sqlpower/matchmaker/swingui/SwingSessionContextImpl.java |
654 |
Avoid empty catch blocks |
| 102 |
ca/sqlpower/matchmaker/swingui/TranslateWordsEditor.java |
286 |
These nested if statements could be combined |
| 103 |
ca/sqlpower/matchmaker/swingui/TranslateWordsEditor.java |
299 |
These nested if statements could be combined |
| 104 |
ca/sqlpower/matchmaker/swingui/TranslateWordsEditor.java |
312 |
These nested if statements could be combined |
| 105 |
ca/sqlpower/matchmaker/swingui/TranslateWordsEditor.java |
325 |
These nested if statements could be combined |
| 106 |
ca/sqlpower/matchmaker/swingui/address/AddressLabel.java |
403 |
These nested if statements could be combined |
| 107 |
ca/sqlpower/matchmaker/swingui/engine/EngineWorker.java |
27 |
Avoid unused imports such as 'javax.swing.JTextArea' |
| 108 |
ca/sqlpower/matchmaker/swingui/engine/RunEngineAction.java |
30 |
Avoid unused imports such as 'ca.sqlpower.swingui.SPSwingWorker' |
| 109 |
ca/sqlpower/matchmaker/swingui/engine/RunWarningEngineAction.java |
29 |
Avoid unused imports such as 'ca.sqlpower.swingui.SPSwingWorker' |
| 110 |
ca/sqlpower/matchmaker/swingui/munge/MungePen.java |
889 |
These nested if statements could be combined |
| 111 |
ca/sqlpower/matchmaker/swingui/munge/MungePen.java |
933 |
These nested if statements could be combined |
| 112 |
ca/sqlpower/matchmaker/swingui/munge/MungePen.java |
1073 |
Avoid empty catch blocks |
| 113 |
ca/sqlpower/matchmaker/swingui/munge/MungeStepLibrary.java |
190 |
Avoid empty catch blocks |
| 114 |
ca/sqlpower/matchmaker/swingui/munge/MungeStepLibrary.java |
191 |
Avoid empty catch blocks |
| 115 |
ca/sqlpower/matchmaker/util/CustomBooleanType.java |
112 |
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. |